michael-o commented on a change in pull request #72: [SCM-885] second 
implementation with new API
URL: https://github.com/apache/maven-scm/pull/72#discussion_r188864492
 
 

 ##########
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
 ##########
 @@ -50,11 +50,20 @@ protected abstract ChangeLogScmResult 
executeChangeLogCommand( ScmProviderReposi
     protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repository, ScmFileSet fileSet,
                                                           ScmVersion 
startVersion, ScmVersion endVersion,
                                                           String datePattern )
-        throws ScmException
+            throws ScmException
     {
         throw new ScmException( "Unsupported method for this provider." );
     }
 
+    protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repository, ScmFileSet fileSet,
+                                                          ScmVersion 
endVersion,
+                                                          String datePattern, 
boolean startFromRoot )
+            throws ScmException
+    {
+        // by default let's just delegate to executeChangeLogCommand with both 
start and end versions
+        return executeChangeLogCommand( repository, fileSet, null, endVersion, 
datePattern );
 
 Review comment:
   Just throw `UnsupportedOperationException`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to