michael-o commented on a change in pull request #74: [SCM-885] third
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189380195
##########
File path:
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
##########
@@ -69,14 +69,22 @@ protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repo
return executeChangeLogCommand( repo, fileSet, startDate, endDate,
branch, datePattern, null, null );
}
+ @Override
+ protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repository, ScmFileSet fileSet,
+ ScmVersion version,
String datePattern )
+ throws ScmException
+ {
+ return executeChangeLogCommand( repository, fileSet, null, null, null,
datePattern, null, null, null, version );
+ }
+
protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repo, ScmFileSet fileSet,
- Date startDate, Date
endDate, ScmBranch branch,
- String datePattern,
ScmVersion startVersion,
- ScmVersion
endVersion )
+ Date startDate, Date
endDate, ScmBranch branch,
+ String datePattern,
ScmVersion startVersion,
+ ScmVersion endVersion
)
Review comment:
Indentation looks wrong. `Date` should align on `ScmProviderRepository`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
