[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482815#comment-16482815
]
ASF GitHub Bot commented on MNG-6401:
-------------------------------------
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-390731655
> I know that we have such a case with booleans, where we do not put the
effective field type in the descriptor but String for more flexibility: in this
boolean case, it was about inheritance, to make the difference between
inheriting and overriding with a value.
Then there is a hand-written getter to get the field as boolean (instead of
the internal String)
This is another issue with our interpolation. Can you point me to that
handwritten spot?
> I don't know if we have such cases in Maven core with ints, but the
previous pattern hand-writing a typed getter to int should do the job.
The core model does not use ints, but only booleans for activation.
> switch back to String based interpolation instead of Object interpolation?
I don't see any quality difference between those two, from user POV
> change the field from int to String and add the hand-written getter?
This is going to be hard because a lot of our code relies on the int
#getPort().
If this PR breaks our approach w/o understanding previous motives, I'd stall
it for 3.6.0 or later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cannot interpolate property in proxy port of settings.xml
> ---------------------------------------------------------
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
> Affects Versions: 3.0, 3.5.3
> Reporter: KATADA Junya
> Assignee: Michael Osipov
> Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
> <proxy>
> <id>my_proxy</id>
> <active>true</active>
> <protocol>http</protocol>
> <host>${env.MAVEN_PROXY_HOST_STRING}</host>
> <port>${env.MAVEN_PROXY_PORT_INT}</port>
> <nonProxyHosts>local.net|some.host.com</nonProxyHosts>
> </proxy>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
> <proxy>
> <port>0</port>
> <host>proxy.foo.com</host>
> <nonProxyHosts>local.net|some.host.com</nonProxyHosts>
> <id>my_proxy</id>
> </proxy>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...<port>${env.MAVEN_PROXY_PORT_INT}</port>... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)