[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488003#comment-16488003
]
ASF GitHub Bot commented on SCM-885:
------------------------------------
asfgit closed pull request #70: [SCM-885] allow to use only endVersion in
GitChangeLogCommand
URL: https://github.com/apache/maven-scm/pull/70
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
index 2145eeb83..7aab4e89f 100644
---
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
+++
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
@@ -170,10 +170,10 @@ static Commandline createCommandLine(
GitScmProviderRepository repository, File
if ( startVersion != null )
{
versionRange.append( StringUtils.escape(
startVersion.getName() ) );
+ // range separator needed only if a lower bound
revision is set
+ versionRange.append( ".." );
}
- versionRange.append( ".." );
-
if ( endVersion != null )
{
versionRange.append( StringUtils.escape( endVersion.getName()
) );
diff --git
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommandTest.java
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommandTest.java
index ecc6086fa..f498c5d13 100644
---
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommandTest.java
+++
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommandTest.java
@@ -151,6 +151,14 @@ public void
testCommandLineWithStartVersionAndEndVersionEquals()
+ " -- " + StringUtils.quoteAndEscape(
workingDirectory.getPath(), '"' ) );
}
+ public void testCommandLineWithOnlyEndVersion()
+ throws Exception
+ {
+ testCommandLine( "scm:git:http://foo.com/git";, null, null, new
ScmRevision( "10" ),
+ "git whatchanged --date=iso 10"
+ + " -- " + StringUtils.quoteAndEscape(
workingDirectory.getPath(), '"' ) );
+ }
+
public void testCommandLineWithStartVersionAndEndVersionAndBranch()
throws Exception
{
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Extend GitChangeLogCommand by using revision only
> -------------------------------------------------
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
> Issue Type: Improvement
> Components: maven-scm-provider-gitexe, maven-scm-provider-jgit
> Affects Versions: 1.9.5
> Reporter: Matthieu Brouillard
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
