[ 
https://issues.apache.org/jira/browse/MENFORCER-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517871#comment-16517871
 ] 

Tobias Gruetzmacher commented on MENFORCER-306:
-----------------------------------------------

[~mbenson] Correct, that is the normal use case: You want to define all plugin 
versions in your pom (or any parent), so that plugin versions aren't dependent 
on the super pom, which might define different plugin versions when using 
different maven versions. btw: The super pom is here: 
[https://gitbox.apache.org/repos/asf?p=maven.git;a=blob;f=maven-core/src/main/resources/META-INF/plexus/default-bindings.xml;hb=HEAD]

I attached a repoducer zip:

Fails:
{code:java}
mvn verify{code}
Still works:
{code:java}
mvn verify -Denforcer.version=3.0.0-M1{code}
It seems 
org.apache.maven.plugins.enforcer.RequirePluginVersions.getAllPluginEntries(MavenProject)
 doesn't collect all plugins anymore...

> [REGRESSION] RequirePluginVersions fails
> ----------------------------------------
>
>                 Key: MENFORCER-306
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-306
>             Project: Maven Enforcer Plugin
>          Issue Type: Bug
>    Affects Versions: 3.0.0-M2
>            Reporter: Karl Heinz Marbaise
>            Assignee: Karl Heinz Marbaise
>            Priority: Critical
>             Fix For: 3.0.0
>
>         Attachments: MENFORCER-306.zip, pom.xml
>
>
> I have found that running the {{RequirePluginVersions}} rule on a project 
> with version {{3.0.0-M1}} works fine whereas it fails with version 
> {{3.0.0-M2}}.
> {code}
> [DEBUG] Executing rule: 
> org.apache.maven.plugins.enforcer.RequirePluginVersions
> [DEBUG] RequirePluginVersions.getAllPlugins:
> [DEBUG]   lifecycleMapping = clean
> [DEBUG]   plugins = org.apache.maven.plugins:maven-clean-plugin:2.5:clean
> [DEBUG]     plugin = org.apache.maven.plugins:maven-clean-plugin:2.5:clean
> [DEBUG]     GAV = [org.apache.maven.plugins, maven-clean-plugin, 2.5, clean]
> [DEBUG] RequirePluginVersions.getAllPlugins:
> [DEBUG]   lifecycleMapping = install
> [DEBUG]   plugins = org.apache.maven.plugins:maven-install-plugin:2.4:install
> [DEBUG]     plugin = org.apache.maven.plugins:maven-install-plugin:2.4:install
> [DEBUG]     GAV = [org.apache.maven.plugins, maven-install-plugin, 2.4, 
> install]
> [DEBUG]   lifecycleMapping = deploy
> [DEBUG]   plugins = org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy
> [DEBUG]     plugin = org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy
> [DEBUG]     GAV = [org.apache.maven.plugins, maven-deploy-plugin, 2.7, deploy]
> [DEBUG] RequirePluginVersions.getAllPlugins:
> [DEBUG]   lifecycleMapping = site
> [DEBUG]   plugins = org.apache.maven.plugins:maven-site-plugin:3.3:site
> [DEBUG]     plugin = org.apache.maven.plugins:maven-site-plugin:3.3:site
> [DEBUG]     GAV = [org.apache.maven.plugins, maven-site-plugin, 3.3, site]
> [DEBUG]   lifecycleMapping = site-deploy
> [DEBUG]   plugins = org.apache.maven.plugins:maven-site-plugin:3.3:deploy
> [DEBUG]     plugin = org.apache.maven.plugins:maven-site-plugin:3.3:deploy
> [DEBUG]     GAV = [org.apache.maven.plugins, maven-site-plugin, 3.3, deploy]
> [DEBUG] All Plugins in use: [Plugin [org.tinyjee.dim:doxia-include-macro], 
> Plugin [org.apache.maven.plugins:maven-clean-plugin], Plugin 
> [org.apache.maven.plugins:maven-install-plugin], Plugin 
> [org.apache.maven.plugins:maven-site-plugin], Plugin 
> [org.apache.maven.plugins:maven-deploy-plugin], Plugin 
> [org.jacoco:jacoco-maven-plugin], Plugin 
> [org.apache.maven.plugins:maven-enforcer-plugin]]
> [DEBUG] plugin org.tinyjee.dim:doxia-include-macro not found
> [DEBUG] plugin org.apache.maven.plugins:maven-clean-plugin not found
> [DEBUG] plugin org.apache.maven.plugins:maven-install-plugin not found
> [DEBUG] plugin org.apache.maven.plugins:maven-site-plugin not found
> [DEBUG] plugin org.apache.maven.plugins:maven-deploy-plugin not found
> [DEBUG] plugin org.jacoco:jacoco-maven-plugin not found
> [DEBUG] Adding failure due to exception
> org.apache.maven.enforcer.rule.api.EnforcerRuleException: Some plugins are 
> missing valid versions:(LATEST RELEASE SNAPSHOT are not allowed )
> org.tinyjee.dim:doxia-include-macro.  The version currently in use is 1.1
> org.apache.maven.plugins:maven-clean-plugin.  The version currently in use is 
> 3.0.0
> org.apache.maven.plugins:maven-install-plugin.        The version currently 
> in use is 2.5.2
> org.apache.maven.plugins:maven-site-plugin.   The version currently in use is 
> 3.6
> org.apache.maven.plugins:maven-deploy-plugin.         The version currently 
> in use is 2.8.2
> org.jacoco:jacoco-maven-plugin.       The version currently in use is 0.8.0
> Always define plugin versions! Never use LATEST or RELEASE.
>     at org.apache.maven.plugins.enforcer.RequirePluginVersions.execute 
> (RequirePluginVersions.java:320)
>     at org.apache.maven.plugins.enforcer.EnforceMojo.execute 
> (EnforceMojo.java:194)
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to