[
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543404#comment-16543404
]
ASF GitHub Bot commented on MRESOLVER-36:
-----------------------------------------
slachiewicz closed pull request #18: [MRESOLVER-36] Make slf4j dependency
required
URL: https://github.com/apache/maven-resolver/pull/18
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/maven-resolver-connector-basic/pom.xml
b/maven-resolver-connector-basic/pom.xml
index 0e896bc8..601e356e 100644
--- a/maven-resolver-connector-basic/pom.xml
+++ b/maven-resolver-connector-basic/pom.xml
@@ -62,7 +62,6 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
- <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
diff --git a/maven-resolver-demos/maven-resolver-demo-snippets/pom.xml
b/maven-resolver-demos/maven-resolver-demo-snippets/pom.xml
index 99a11503..733ac99d 100644
--- a/maven-resolver-demos/maven-resolver-demo-snippets/pom.xml
+++ b/maven-resolver-demos/maven-resolver-demo-snippets/pom.xml
@@ -110,7 +110,6 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
- <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
diff --git a/maven-resolver-impl/pom.xml b/maven-resolver-impl/pom.xml
index ddfa9fc0..11365979 100644
--- a/maven-resolver-impl/pom.xml
+++ b/maven-resolver-impl/pom.xml
@@ -75,8 +75,6 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
- <scope>provided</scope>
- <optional>true</optional>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
diff --git a/maven-resolver-transport-file/pom.xml
b/maven-resolver-transport-file/pom.xml
index ee670189..70445a47 100644
--- a/maven-resolver-transport-file/pom.xml
+++ b/maven-resolver-transport-file/pom.xml
@@ -79,7 +79,6 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
- <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
diff --git a/maven-resolver-transport-http/pom.xml
b/maven-resolver-transport-http/pom.xml
index dce3dcd9..533150d1 100644
--- a/maven-resolver-transport-http/pom.xml
+++ b/maven-resolver-transport-http/pom.xml
@@ -125,7 +125,6 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
- <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
diff --git a/maven-resolver-transport-wagon/pom.xml
b/maven-resolver-transport-wagon/pom.xml
index 5371d2a7..7a980ab4 100644
--- a/maven-resolver-transport-wagon/pom.xml
+++ b/maven-resolver-transport-wagon/pom.xml
@@ -111,7 +111,6 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
- <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
diff --git a/pom.xml b/pom.xml
index 8ccbfdbb..edaad986 100644
--- a/pom.xml
+++ b/pom.xml
@@ -203,7 +203,6 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>${slf4jVersion}</version>
- <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SLFJ - remove LoggerFactory from dependency injection
> -----------------------------------------------------
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
> Issue Type: Improvement
> Components: resolver
> Affects Versions: Maven Artifact Resolver 1.1.1
> Reporter: Sylwester Lachiewicz
> Assignee: Olivier Lamy (*$^¨%`£)
> Priority: Minor
> Fix For: Maven Artifact Resolver 1.1.2
>
>
> Because Maven moved to SL4J as the primary login structure we can remove
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
