yborovikov commented on a change in pull request #175: [MNG-6450] - Allow
importing a POM with a classifier
URL: https://github.com/apache/maven/pull/175#discussion_r205275754
##########
File path:
maven-model-builder/src/test/java/org/apache/maven/model/validation/DefaultModelValidatorTest.java
##########
@@ -607,15 +607,12 @@ public void testBadImportScopeType()
"'dependencyManagement.dependencies.dependency.type'
for test:a:jar must be 'pom'" );
}
- public void testBadImportScopeClassifier()
+ public void testImportScopeClassifier()
throws Exception
{
- SimpleProblemCollector result = validateRaw(
"bad-import-scope-classifier.xml" );
+ SimpleProblemCollector result = validateRaw(
"import-scope-classifier.xml" );
- assertViolations( result, 0, 1, 0 );
-
- assertContains( result.getErrors().get( 0 ),
-
"'dependencyManagement.dependencies.dependency.classifier' for test:a:pom:cls
must be empty" );
+ assertViolations( result, 0, 0, 0 );
Review comment:
Hi @KathrynN, thank you for looking at the diff!
The `assertViolations( result, 0, 0, 0 );` is used in 5 other test methods
in addition to the one I've edited. Changing these would expand the scope of
this concise diff to those unrelated test cases - is it, in your opinion,
justified?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
