[ 
https://issues.apache.org/jira/browse/MNGSITE-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564291#comment-16564291
 ] 

ASF GitHub Bot commented on MNGSITE-343:
----------------------------------------

khmarbaise closed pull request #25: [MNGSITE-343] doc updated to be more clear 
about the plugin management
URL: https://github.com/apache/maven-site/pull/25
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/content/apt/pom.apt b/content/apt/pom.apt
index fb2224a6..cea326b1 100644
--- a/content/apt/pom.apt
+++ b/content/apt/pom.apt
@@ -1218,8 +1218,8 @@ Display parameters as parsed by Maven (in canonical form) 
and comparison result:
   is an element that is seen along side plugins. Plugin Management contains 
plugin elements in much
   the same way, except that rather than configuring plugin information for 
this particular project build,
   it is intended to configure project builds that inherit from this one. 
However, this only configures
-  plugins that are actually referenced within the plugins element in the 
children. The children have every
-  right to override <<<pluginManagement>>> definitions.
+  plugins that are actually referenced within the plugins element in the 
children or in the current POM.
+  The children have every right to override <<<pluginManagement>>> definitions.
 
   []
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Correct the documentation for the plugin management
> ---------------------------------------------------
>
>                 Key: MNGSITE-343
>                 URL: https://issues.apache.org/jira/browse/MNGSITE-343
>             Project: Maven Project Web Site
>          Issue Type: Improvement
>            Reporter: Martin Prochazka
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>              Labels: easyfix
>
> In the documentation of the plugin management element it says that the plugin 
> management relates *only* to children, however maven behaves differently. The 
> following pom creates also a jar with dependencies, even by documentation it 
> should not be configured to do so.
> The solution is to change a few words in the documentation.
> {code:java}
> <?xml version="1.0" encoding="UTF-8"?>
> <project xmlns="http://maven.apache.org/POM/4.0.0";
>          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
>     <modelVersion>4.0.0</modelVersion>
>     <groupId>someproject</groupId>
>     <artifactId>someartifact</artifactId>
>     <version>1.0-SNAPSHOT</version>
>     <build>
>         <pluginManagement>
>             <plugins>
>                 <plugin>
>                     <artifactId>maven-assembly-plugin</artifactId>
>                     <version>3.1.0</version>
>                     <configuration>
>                         <descriptorRefs>
>                             
> <descriptorRef>jar-with-dependencies</descriptorRef>
>                         </descriptorRefs>
>                     </configuration>
>                     <executions>
>                         <execution>
>                             <id>make-assembly</id> 
>                             <phase>package</phase>
>                             <goals>
>                                 <goal>single</goal>
>                             </goals>
>                         </execution>
>                     </executions>
>                 </plugin>
>             </plugins>
>         </pluginManagement>
>         <plugins>
>             <plugin>
>                 <artifactId>maven-assembly-plugin</artifactId>
>             </plugin>
>         </plugins>
>     </build>
> </project>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to