[
https://issues.apache.org/jira/browse/MCOMPILER-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565181#comment-16565181
]
ASF GitHub Bot commented on MCOMPILER-349:
------------------------------------------
atsyganenko opened a new pull request #6: [MCOMPILER-349] - changed dependency
detection.
URL: https://github.com/apache/maven-compiler-plugin/pull/6
Issue description:
Module doesn't recompile when its dependency is changed and `mvn compile` is
runned (without `clean`)
Reason: Bug in changed dependency detection mechanism
Default fileExtensions contained '.class', while FileUtils#getExtension(
method used in AbstractCompilerMojo#hasNewFile returns file extension without
'.' (e.g. 'class')
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MPH-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MPH-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> maven-compiler-plugin does not recompile a module if a dependency module has
> been updated & recompiled
> ------------------------------------------------------------------------------------------------------
>
> Key: MCOMPILER-349
> URL: https://issues.apache.org/jira/browse/MCOMPILER-349
> Project: Maven Compiler Plugin
> Issue Type: Bug
> Reporter: Ahmet Bolac
> Priority: Major
>
> We have two modules A and B, where A depends on B. When running an
> incremental build, we observe that if the sources of A has not changed, but
> sources of B has been changed, module B gets recompiled as expected, but then
> module A is considered up-to-date and not recompiled. If there are any
> breaking changes in module B, we would expect A to fail compilation but it
> does not happen when running an incremental build. We only see A recompile
> after a clean.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
