[ 
https://issues.apache.org/jira/browse/SCM-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577294#comment-16577294
 ] 

ASF GitHub Bot commented on SCM-891:
------------------------------------

michael-o commented on a change in pull request #82: SCM-891
URL: https://github.com/apache/maven-scm/pull/82#discussion_r209435495
 
 

 ##########
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/util/ConsumerUtils.java
 ##########
 @@ -0,0 +1,55 @@
+package org.apache.maven.scm.util;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.FileReader;
+import java.io.IOException;
+
+import org.codehaus.plexus.util.cli.StreamConsumer;
+
+/**
+ * @author <a href="mailto:davide.angelocola+apa...@gmail.com";>Davide 
Angelocola</a>
+ */
+public class ConsumerUtils {
+
+       private ConsumerUtils() {
+       }
+
+       /**
+        * Read file f, sending each line to the consumer. 
+        * @param f
+        * @param consumer
+        * @throws IOException
+        */
+       public static void consumeFile(File f, StreamConsumer consumer) throws 
IOException {
+               BufferedReader r = new BufferedReader(new FileReader(f));
+               try {
+                       String line;
+                       while ((line = r.readLine()) != null) {
+                               consumer.consumeLine(line);
+                       }
+
+               } finally {
+                       r.close();
+               }
+       }
+}
 
 Review comment:
   Please reformat the class according to our rules.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> remove duplication in tests
> ---------------------------
>
>                 Key: SCM-891
>                 URL: https://issues.apache.org/jira/browse/SCM-891
>             Project: Maven SCM
>          Issue Type: Improvement
>    Affects Versions: 1.10.0
>            Reporter: Davide Angelocola
>            Assignee: Michael Osipov
>            Priority: Trivial
>             Fix For: 1.10.1
>
>
> Introduce a shared utility method to send a text file, line by line, into a
> {code:java}
> StreamConsumer{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to