[ 
https://issues.apache.org/jira/browse/SCM-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577300#comment-16577300
 ] 

ASF GitHub Bot commented on SCM-486:
------------------------------------

michael-o commented on a change in pull request #81: SCM-486
URL: https://github.com/apache/maven-scm/pull/81#discussion_r209435687
 
 

 ##########
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/tag/GitTagCommandTest.java
 ##########
 @@ -78,7 +78,7 @@ private void testCommandLine( String scmUrl, String tag, 
String commandLine )
 
         GitScmProviderRepository gitRepository = (GitScmProviderRepository) 
repository.getProviderRepository();
 
-        Commandline cl = GitTagCommand.createCommandLine( gitRepository, 
workingDirectory, tag, messageFile );
+        Commandline cl = GitTagCommand.createCommandLine( gitRepository, 
workingDirectory, tag, messageFile, false );
 
 Review comment:
   Why don't you add the sign case and validate the command line?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support signed tags for git when releasing
> ------------------------------------------
>
>                 Key: SCM-486
>                 URL: https://issues.apache.org/jira/browse/SCM-486
>             Project: Maven SCM
>          Issue Type: Wish
>          Components: maven-scm-provider-gitexe
>            Reporter: Chris Searle
>            Priority: Major
>             Fix For: 1.x
>
>         Attachments: SCM-486_sign_git_tags.diff
>
>
> When tagging the release - it would be nice if the git plugin for scm allowed 
> for an annotated and signed tag rather than just an annotated tag.
> If this is already possible then either I need a pointer to the correct doc 
> ;) (or it would be nice if the doc covered how to configure it).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to