Tibor17 commented on a change in pull request #192: [SUREFIRE-1550] The 
surefire XSD published on maven site lacks of some
URL: https://github.com/apache/maven-surefire/pull/192#discussion_r210389899
 
 

 ##########
 File path: 
maven-surefire-plugin/src/site/resources/xsd/surefire-test-report.xsd
 ##########
 @@ -18,6 +18,11 @@
   ~ under the License.
   -->
 <xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema";>
+    <xs:simpleType name="SUREFIRE_TIME">
+        <xs:restriction base="xs:string">
+            <xs:pattern 
value="(([0-9]{0,3},)*[0-9]{3}|[0-9]{0,3})*(\.[0-9]{0,3})?"/>
 
 Review comment:
   I think this pattern is also not correct because the fractions separator 
should be (.) and not (,). The formatter uses English, see class 
`ReporterUtils`. WDYT?
   ```
   NumberFormat numberFormat = NumberFormat.getInstance( Locale.ENGLISH );
   return numberFormat.format( runTime / MS_PER_SEC );
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to