docrjp edited a comment on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 support URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416688877 That would be good! But are the different use cases for ASM in Maven sufficiently similar to do so? Probably stating the obvious, but creating any ASM-like visitor pattern on top of ASM is merely moving the problem on; and all the analysis that is quite correct of ASM would apply to the Maven shared code also; i.e. we wouldn't want hard-to-debug errors due to silently ignoring incompatible changes. So are we talking about literally moving all the code and then those ASM-related aspects of the affected maven plugins are done in a shared library, even if they are very specific use cases? I suppose that would be OK. The uses of ASM in Maven plugin tools, would be mojo annotation analysis and use of an ASM remapper. In plexus-languages, ASM is used to read module-info.java. These are already quite specific use cases in shared utility projects. How do we enumerate all other cases for official maven plugins?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
