[
https://issues.apache.org/jira/browse/MENFORCER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604250#comment-16604250
]
ASF GitHub Bot commented on MENFORCER-317:
------------------------------------------
famod edited a comment on issue #40: MENFORCER-317 - Fix RequireFileChecksum
ignores configured message
URL: https://github.com/apache/maven-enforcer/pull/40#issuecomment-418681667
@khmarbaise Your are welcome!
One thing that crossed my mind though: First I wanted change the rule to use
the configured message also [when the given file does not
exist](https://github.com/apache/maven-enforcer/blob/master/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireFileChecksum.java#L72).
But then I decided against this because that might be slighty out of scope
because the is also `RequireFilesExist`.
On the other hand it would reduce the "configuration noise" if
`RequireFileChecksum` could also check for file existence, using the configured
message.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> RequireFileChecksum ignores configured message
> ----------------------------------------------
>
> Key: MENFORCER-317
> URL: https://issues.apache.org/jira/browse/MENFORCER-317
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
> Affects Versions: 3.0.0-M2
> Reporter: Falko Modler
> Priority: Major
> Labels: up-for-grabs
> Fix For: 3.0.0
>
>
> The [documentation for RequireFileChecksum
> |https://maven.apache.org/enforcer/enforcer-rules/requireFileChecksum.html]
> says, that you can set a {{message}} that is used for a violation message.
> However, this configuable attribute coming from
> {{AbstractStandardEnforcerRule}} is simply ignored/not evaluated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
