[
https://issues.apache.org/jira/browse/MNG-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694297#comment-14694297
]
Hervé Boutemy edited comment on MNG-5870 at 9/16/18 4:07 PM:
-------------------------------------------------------------
like written in MPIR-234, removing scm info from effective model is IMHO
throwing baby with bath water: a module has a scm, even if it's inside a git
repo for example then not immediately a git repo!
then I'm -1 for this idea of removing scm inheritance
instead, scm urls for any artifact should exist: extending Maven scm url
formats to make sure that they take into account path inside repo would not be
that complex (and would not require any change in Maven core): MPIR should use
Maven SCM provider to parse the scm url and extract info
was (Author: hboutemy):
like written in MPIR-234, removing scm info from effective model is IMHO
throwing baby with bath: a module has a scm, even if it's inside a git repo for
example!
then I'm -1 for this idea of removing scm inheritance
instead, scm urls for any artifact should exist: extending Maven scm url
formats to make sure that they take into account path inside repo would not be
that complex (and would not require any change in Maven core): MPIR should use
Maven SCM provider to parse the scm url and extract info
> Effective pom should not inherit SCM
> ------------------------------------
>
> Key: MNG-5870
> URL: https://issues.apache.org/jira/browse/MNG-5870
> Project: Maven
> Issue Type: Improvement
> Components: core, Inheritance and Interpolation, POM
> Reporter: Robert Scholte
> Priority: Major
>
> Up until Maven 3.3.7 if a pom didn't specify the scm section, it would be
> inherited and extended with the artifactId *by default*. This mechanism could
> work for a couple of SCMs like svn and cvs, but for most it doesn't.
> This kind of scm specific logic of extending the connection or URL doesn't
> belong in Maven core.
> Instead we should say that scm marks this project as a valid release root.
> The source repository page (mpir) should ask a specific Scm class for
> handling connections and urls in case of modules.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
