michael-o commented on a change in pull request #10: [MRESOLVER-7] Download 
dependency POMs in parallel v2
URL: https://github.com/apache/maven-resolver/pull/10#discussion_r220323887
 
 

 ##########
 File path: 
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
 ##########
 @@ -91,6 +98,13 @@
 
     private VersionRangeResolver versionRangeResolver;
 
+    private static final ThreadGroup THREAD_GROUP = new ThreadGroup( "Maven 
Resolver dependency resolution" );
+
+    /**
+     * Setup executor with 5 daemon threads in pool, max to 10 concurrent and 
keep alive to 10 sec inactivity.
 
 Review comment:
   `10 sec` to > `10 s`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to