rfscholte commented on a change in pull request #2: [MJAR-238] Allow setting of
module main class
URL: https://github.com/apache/maven-jar-plugin/pull/2#discussion_r221466423
##########
File path: src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
##########
@@ -76,7 +76,7 @@
/**
* The Jar archiver.
*/
- @Component( role = Archiver.class, hint = "jar" )
+ @Component( role = Archiver.class, hint = "mjar" )
Review comment:
Let's change this to
@Component
private Map<String, Archiver> archivers;
Now we have the option to decide which archiver to pick, e.g. based on the
availability of the module descriptor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services