[
https://issues.apache.org/jira/browse/MJAR-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633443#comment-16633443
]
ASF GitHub Bot commented on MJAR-238:
-------------------------------------
rfscholte commented on a change in pull request #2: [MJAR-238] Allow setting of
module main class
URL: https://github.com/apache/maven-jar-plugin/pull/2#discussion_r221466423
##########
File path: src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
##########
@@ -76,7 +76,7 @@
/**
* The Jar archiver.
*/
- @Component( role = Archiver.class, hint = "jar" )
+ @Component( role = Archiver.class, hint = "mjar" )
Review comment:
Let's change this to
@Component
private Map<String, Archiver> archivers;
Now we have the option to decide which archiver to pick, e.g. based on the
availability of the module descriptor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Allow setting of module main class
> ----------------------------------
>
> Key: MJAR-238
> URL: https://issues.apache.org/jira/browse/MJAR-238
> Project: Maven JAR Plugin
> Issue Type: Improvement
> Environment: Java9 build 9+176, MacOS
> Reporter: Machiel Groeneveld
> Assignee: Robert Scholte
> Priority: Minor
>
> When a Java9 module is created using the maven-jar plugin, setting the
> manifest/mainclass does not set the module main class. Therefore the module
> is not executable without specifying the main class. Executing the module
> using java -m domain.app gives the following error:
> _module jigsaw.app does not have a MainClass attribute_
> According to the module specification a module (jar) can have a main class
> set. If I understand correctly it's inside the module-info.class as a
> property called ModuleMainClass
> When using the JDK9 jar command it will update the jar and the
> module-info.class.
> {noformat}
> -e, --main-class=CLASSNAME The application entry point for stand-alone
> applications bundled into a modular, or
> executable,
> jar archive
> {noformat}
> I guess it would make sense to have this as a separate configuration item
> since the mainclass entry in the manifest file is not needed in 'module mode'
> and vice versa.
> If this is a duplicate of another issue, please close this one, I couldn't
> find any existing issues related to this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)