rfscholte commented on a change in pull request #15: [MPLUGIN-336] Jdk11 asm7
URL: https://github.com/apache/maven-plugin-tools/pull/15#discussion_r222979508
 
 

 ##########
 File path: maven-plugin-plugin/pom.xml
 ##########
 @@ -390,6 +390,25 @@
         </plugins>
       </build>
     </profile>
+    <profile>
 
 Review comment:
   There's a more generic solution for this, which will also work when we must 
move to TLSv1.3
   
                 <properties>
                   <!-- e.g. ensure that Java7 picks up TLSv1.2 when connecting 
with Central -->
                   <https.protocols>${https.protocols}</https.protocols>
                 </properties>
   
   No reason for a profile. If `https.protocols` is used as argument, it is 
passed to invoker.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to