khmarbaise commented on a change in pull request #1: [MWAR-371] - Overlays break first-win rule for web resource with target path ending with '/' URL: https://github.com/apache/maven-war-plugin/pull/1#discussion_r223189332
########## File path: src/it/MWAR-371/custom/pom.xml ########## @@ -0,0 +1,47 @@ +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>mwar371</groupId> + <artifactId>mwar371</artifactId> + <version>0.0.1-SNAPSHOT</version> + </parent> + <artifactId>custom</artifactId> + <packaging>war</packaging> + <dependencies> + <dependency> + <groupId>mwar371</groupId> + <artifactId>generic</artifactId> + <version>0.0.1-SNAPSHOT</version> + <type>war</type> + </dependency> + </dependencies> + <build> + + <plugins> + <plugin> + <artifactId>maven-war-plugin</artifactId> + <version>3.2.3-SNAPSHOT</version> + <configuration> Review comment: The hard coded version is not a good idea...you should look at the other IT's as an example how to do this correctly. `@project.version@` .... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
