[ 
https://issues.apache.org/jira/browse/MCOMPILER-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642048#comment-16642048
 ] 

Didier Loiseau commented on MCOMPILER-205:
------------------------------------------

I found [~jens.b]'s [answer on Stack 
Overflow|https://stackoverflow.com/a/49700942/525036] (also quoting 
[~rfscholte]'s previous comment) explains this very well.

It seems clear that the logic of the flag is *not* inverted. However the flag 
itself is not clear, since the plugin is incremental in both cases. The flag 
should thus be something like {{useSmartIncrementalCompilation}} or 
{{useFullDependencyChangeDetection}} or inverted to 
{{useNaiveIncrementalCompilation}} or {{useNaiveChangeDetection}}.

> maven-compiler-plugin: incremental compilation broken
> -----------------------------------------------------
>
>                 Key: MCOMPILER-205
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-205
>             Project: Maven Compiler Plugin
>          Issue Type: Bug
>    Affects Versions: 3.1
>            Reporter: Lukas Fryc
>            Priority: Major
>         Attachments: hello.tgz, ignore-package-info.patch, 
> no-class-in-java-file.zip, only-recompile-changed.patch
>
>
> When we do {{clean}} -> {{compile}} -> {{compile}}, all Java sources are 
> re-compiled for second compilation steps:
> {code}
> [framework]$ mvn clean
> ...
> [framework]$ mvn compile
> ...
> [INFO] --- maven-compiler-plugin:3.1:compile (precompile-sources-for-cdk) @ 
> richfaces-framework ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 915 source files to 
> /mnt/workspace/workspaces/richfaces/richfaces5/framework/target/classes
> ...
> [framework]$ mvn compile
> ...
> [INFO] --- maven-compiler-plugin:3.1:compile (precompile-sources-for-cdk) @ 
> richfaces-framework ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 915 source files to 
> /mnt/workspace/workspaces/richfaces/richfaces5/framework/target/classes
> ...
> {code}
> The source code of the affected project: 
> https://github.com/richfaces/richfaces5/tree/077dcfc0a46d03d7ba9a7ac3e701a4adfb834c71



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to