sormuras commented on a change in pull request #196: [SUREFIRE-1585] [WIP]
Resolve missing artifact
URL: https://github.com/apache/maven-surefire/pull/196#discussion_r228053571
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/TestClassPath.java
##########
@@ -69,9 +70,9 @@ void avoidArtifactDuplicates( Set<Artifact>
providerArtifacts )
&& ( classifier1 == null ? classifier2 == null :
classifier1.equals( classifier2 ) ) )
{
it.remove();
- if ( logger.isDebugEnabled() )
+ if ( mojo != null && mojo.getLog().isDebugEnabled() )
Review comment:
Ad 1 and 2: I'm trying to move the logic into the
`ProviderInfo::getProviderClasspath`. The "null-checks" are needed though.
Ad 3: See the second method named `adoptArtifactVersions`. It will care
about aligning versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
