[
https://issues.apache.org/jira/browse/SUREFIRE-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666018#comment-16666018
]
ASF GitHub Bot commented on SUREFIRE-1532:
------------------------------------------
based2 closed pull request #188: [SUREFIRE-1532] MIME type for javascript is
now officially application/javascript
URL: https://github.com/apache/maven-surefire/pull/188
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
index f9b948091..6c02ad948 100644
---
a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
+++
b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
@@ -78,7 +78,7 @@ public void doGenerateReport( LocalizedProperties bundle,
Sink sink )
sink.body();
SinkEventAttributeSet atts = new SinkEventAttributeSet();
- atts.addAttribute( TYPE, "text/javascript" );
+ atts.addAttribute( TYPE, "application/javascript" );
sink.unknown( "script", new Object[]{ HtmlMarkup.TAG_TYPE_START },
atts );
sink.unknown( "cdata", new Object[]{ HtmlMarkup.CDATA_TYPE,
javascriptToggleDisplayCode() }, null );
sink.unknown( "script", new Object[]{ HtmlMarkup.TAG_TYPE_END }, null
);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> MIME type for javascript is now officially application/javascript
> -----------------------------------------------------------------
>
> Key: SUREFIRE-1532
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1532
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Report Plugin
> Affects Versions: 2.22.0
> Reporter: Basile Chandesris
> Assignee: Tibor Digana
> Priority: Minor
> Labels: easyfix
> Fix For: 2.22.1
>
>
>
> ref [http://www.rfc-editor.org/rfc/rfc4329.txt
> |http://www.rfc-editor.org/rfc/rfc4329.txt]Scripting Media Types
> src
> [https://stackoverflow.com/questions/189850/what-is-the-javascript-mime-type-for-the-type-attribute-of-a-script-tag]
> "This is a common mistake. The MIME type for javascript wasn't standardized
> for years. It's now officially: "application/javascript"."
> github
> https://github.com/apache/maven-surefire/pull/188#issuecomment-401559853
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)