plamentotev edited a comment on issue #2: [MJAR-238] Allow setting of module main class URL: https://github.com/apache/maven-jar-plugin/pull/2#issuecomment-433637874 @rfscholte if we check only in the root of the archive we may get false negatives. The `module-info.class` can be in `META-INF/versions/` (I've updated the code so now it works with multi-release jars as well). Maybe we can check the sub-directories of `META-INF/versions/` before evaluating the included/excluded files, but not sure if it is worth it. Especially given that `majr` can handle regular Jar files as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
