Tibor17 commented on a change in pull request #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#discussion_r230360224
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
##########
@@ -114,7 +115,7 @@ private File createJar( @Nonnull List<String> classPath,
@Nonnull String startCl
{
File file1 = new File( it.next() );
- String uri = parent.relativize( file1.toPath() ).toString();
+ String uri = URI.create( parent.relativize( file1.toPath()
).toString() ).toASCIIString();
Review comment:
AFAIK our users, they won't see any warnings. So. We should write the log
down to a dump file, see `InPluginProcessDumpSingleton`. I do not think it is
user error. You need to specify reports dir and pass it to the class because
the `InPluginProcessDumpSingleton` requires the dir.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
