cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435506871
 
 
   Btw, second look:
   
   SiblingAggregatorIT POMs are not using `it-parent`, so that IT is kinda 
fluke, it always tests with use Maven (3.6.0 it my case) Super-POM defined 
surefire, not the built one. So it will never pass on affected JDK.
   
   Surefire162CharsetProviderIT copied the jcharset into wrong repo, this is 
why it did not found the artifact in local repo: it copied it to 
`surefire-its/${env.HOME}/.m2/repository-oss/jcharset/jcharset/1.2.1/jcharset-1.2.1.jar`,
 like did not interpolate things. Yes, my settings.xml defines my local repo as 
`${env.HOME}/.m2/repository-oss`.
   
   and finally, the Surefire1535TestNGParallelSuitesIT failure you got, don't 
know what is it about, but: seems you are on Windows and you have local repo 
and maven workdir on different drive letters. With affected JDK and this kind 
of Windows setup this PR will not work. Unlike UN*X, Windows due drive letter 
will not be able to "relativise" paths like these.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to