[
https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680013#comment-16680013
]
ASF GitHub Bot commented on SUREFIRE-1593:
------------------------------------------
Tibor17 commented on a change in pull request #198: [SUREFIRE-1593] Correcting
relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#discussion_r231979549
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
##########
@@ -150,10 +150,9 @@ private static String toClasspathElementUri( @Nonnull
Path parent,
{
try
{
- return new URI( null,
- parent.relativize( classPathElement.toPath()
).toString().
- replace( File.separatorChar, '/' ),
- null ).toASCIIString();
+ Path relativePath = parent.relativize( classPathElement.toPath() );
Review comment:
This won't tested by ITs because we cannot occupy any disk on Jenkins, but
this algorithm could be tested by unit test and Mockito. At least Line 153 in
mock and next two lines are real and tested. If the Line went to private static
method, we could mock it via PowerMock, and then the next two lines together in
another method calling the first static method. We would assert the returned
value has Unix slashes and white spaces are escaped, paths are relative, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> 3.0.0-M1 produces invalid code sources on Windows
> -------------------------------------------------
>
> Key: SUREFIRE-1593
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1593
> Project: Maven Surefire
> Issue Type: Bug
> Components: classloading, process forking
> Affects Versions: 3.0.0-M1
> Reporter: Jesse Glick
> Priority: Major
>
> The fix for SUREFIRE-1588 did not work correctly on Windows. (When
> active—i.e., when the drive letters of the system temporary directory, per
> SUREFIRE-1400, and the project basedir were the same.) It would produce
> relative URIs containing {{%5C}} where {{/}} was intended.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
