[
https://issues.apache.org/jira/browse/MSHADE-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682407#comment-16682407
]
ASF GitHub Bot commented on MSHADE-291:
---------------------------------------
rfscholte commented on issue #9: [MSHADE-291] - Fixes bug in SimpleRelocator
URL: https://github.com/apache/maven-shade-plugin/pull/9#issuecomment-437584613
This PR looks good, see
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-shade-plugin/job/MSHADE-291/
If you add yourself as contributor in the pom and squash the commits, I'll
merge them into master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> shadedPattern applied multiples times when relocating the contents of
> META-INF/services files
> ---------------------------------------------------------------------------------------------
>
> Key: MSHADE-291
> URL: https://issues.apache.org/jira/browse/MSHADE-291
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 3.1.1
> Reporter: Jan Luehe
> Priority: Major
> Labels: up-for-grabs
>
> Steps to reproduce:
> 1. Modified the test case for
> https://issues.apache.org/jira/browse/MSHADE-190, as follows:
> {code:java}
> diff --git a/pom.xml b/pom.xml
> index 746b700..aea9abb 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -68,12 +68,12 @@
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-shade-plugin</artifactId>
> - <version>2.4</version>
> + <version>3.1.1</version>
> <configuration>
> <relocations>
> <relocation>
> - <pattern>org.eclipse.*</pattern>
> - <shadedPattern>borg.eclipse.*</shadedPattern>
> + <pattern>org.eclipse</pattern>
> + <shadedPattern>org.eclipse1234</shadedPattern>
> </relocation>
> </relocations>
> <transformers>
> {code}
> 2. mvn package
> 3. jar -xvf target/shade-meta-tc-1.0-SNAPSHOT.jar META-INF/services
> 4. cat META-INF/services/org.osgi.framework.launch.FrameworkFactory
> The shaded service implementation class looks as follows:
> {code:java}
> org.eclipse12341234.osgi.launch.EquinoxFactory
> {code}
> It appears that shadedPattern was applied twice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
