Tibor17 commented on a change in pull request #198: [SUREFIRE-1593] Correcting
relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#discussion_r232479128
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
##########
@@ -150,10 +150,9 @@ private static String toClasspathElementUri( @Nonnull
Path parent,
{
try
{
- return new URI( null,
- parent.relativize( classPathElement.toPath()
).toString().
- replace( File.separatorChar, '/' ),
- null ).toASCIIString();
+ Path relativePath = parent.relativize( classPathElement.toPath() );
Review comment:
@jglick
Not sure about Vagrant but I know that Docker works with Windows 10.
our Jenkins in ASF has Windows server 2008.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
