[
https://issues.apache.org/jira/browse/MRRESOURCES-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696536#comment-16696536
]
ASF GitHub Bot commented on MRRESOURCES-102:
--------------------------------------------
rfscholte commented on a change in pull request #2: Implement MRRESOURCES-102
URL:
https://github.com/apache/maven-remote-resources-plugin/pull/2#discussion_r235874669
##########
File path:
src/main/java/org/apache/maven/plugin/resources/remote/ProcessRemoteResourcesMojo.java
##########
@@ -944,12 +944,12 @@ private void fileWriteIfDiffers(
DeferredFileOutputStream outStream )
}
}
- private MavenFileFilterRequest setupRequest( File source, File file,
boolean isFiltering )
+ private MavenFileFilterRequest setupRequest( File source, File file )
{
MavenFileFilterRequest req = new MavenFileFilterRequest();
req.setFrom( source );
req.setTo( file );
- req.setFiltering( isFiltering );
+ req.setFiltering( true );
Review comment:
But this filtering ***always*** active, is that what we want?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Filtering of non-.vm files
> --------------------------
>
> Key: MRRESOURCES-102
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-102
> Project: Maven Remote Resources Plugin
> Issue Type: New Feature
> Affects Versions: 1.5
> Reporter: Falko Modler
> Priority: Major
>
> It would be a very welcomed addition if the plugin would also filter
> non-verlocity (.vm) files.
> See also: MRRESOURCES-83
> Renaming the files in question to *.vm is not an option for me because:
> - MRRESOURCES-94
> - the module _providing_ the file(s) also needs them _without_ .vm suffix
> (fixing this would require some other plugin)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
