[
https://issues.apache.org/jira/browse/MNG-6530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702350#comment-16702350
]
Mickael Istria commented on MNG-6530:
-------------------------------------
{quote}Reverting
MNG-6311
would imply reverting
MNG-6030
too, and maybe even more. {quote}
I don't get why. MNG-6030 was fixed almost 2 years ago and no-one complained
about it. The change for MNG-6311 are downstream of this one,so they could be
reverted without affecting older patches.
{quote}This has become an Eclipse intregration issue, {quote}
Not only, it's an API regression. M2e noticed it, but there are chances that
any user of ProjectBuilder API could be affected.
I see you're trying to diminosh the criticity of the issue and try to put
responsibility of the regression on the users. I also do it too from time to
time, but deep inside me., I know I'm very wrong when I do that and that the
tolerated technical debt will come back to me even stronger in the future.
{quote} for all others these changes are improvements, so reverting just for
Eclipse doesn't sound good to me{quote}
Do you have an exhaustuve listing of «all others»? There are strong chances
that any tool providing Maven integration (read about all IDEs) do use this API
to generate info and assistance to edit the pom file.
{quote}Instead we (Maven team + Eclipse team) should cooperate and keep
improving Maven.{quote}
Sure, and that's what I'm doing with my former comment, I.just reached
my.technical limit in term of what I can develop here because of my lack of
knowledge in Maven. The ball is now on the side of Maven contributors.
{quote}Worst case we're going to introduce a system property to disable
caching{quote}
That'd be pretty good to me. If I submit a.patch with that,would it be accepted?
{quote}I would expect that caching would be interesting for Eclipse too,{quote}
Of course.
{quote}as long as it recognizes changes to the pomfile.{quote}
Basically,is there any chance it happens soon? My look at the code today made
me pissimistic, as explained in the previous comment.if you can send
optimisitic perspectives of this being fixed.soon, it may make me feel better
about.m2e and Maven.
> Regression in ProjectBuilder when file change between invocations (introduced
> by MNG-6311)
> ------------------------------------------------------------------------------------------
>
> Key: MNG-6530
> URL: https://issues.apache.org/jira/browse/MNG-6530
> Project: Maven
> Issue Type: Bug
> Components: core
> Affects Versions: 3.6.0, 3.6.1
> Reporter: Mickael Istria
> Priority: Critical
>
> The patch for MNG-6311 introduces a regression in ProjectBuilder due to
> missing cache invalidation when content change.
> It was identified as a potential issue by [~fbricon] on Oct 10, yet no
> further investigation happened and Maven 3.6.0 was released with this
> regression.
> This regression prevents Eclipse m2e (and probably most APIs using the
> ProjectBuilder for a longer session which allows pom.xml files to be
> modified) from adopting 3.6.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
