michael-o commented on a change in pull request #194: MNG-6350 - Test + System 
property to disable global model cache
URL: https://github.com/apache/maven/pull/194#discussion_r238850091
 
 

 ##########
 File path: 
maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java
 ##########
 @@ -355,7 +365,8 @@ private ModelSource createStubModelSource( Artifact 
artifact )
 
         ReactorModelPool modelPool = new ReactorModelPool();
 
-        InternalConfig config = new InternalConfig( request, modelPool );
+        InternalConfig config = new InternalConfig( request, modelPool,
+                useGlobalModelCache() ? getModelCache() : new 
ReactorModelCache() );
 
 Review comment:
   Why are you passing `new ReactorModelCache()` when you are passing `null` 60 
lines above?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to