[
https://issues.apache.org/jira/browse/MRESOLVER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709408#comment-16709408
]
Hervé Boutemy edited comment on MRESOLVER-64 at 12/5/18 12:18 AM:
------------------------------------------------------------------
method added back to the 2 classes that broke IDEA:
https://github.com/apache/maven-resolver/commit/b2eeafe26d5901abbdf341d2d8c6d68f08c5a99b
looking at MRESOLVER-36 fix
https://github.com/apache/maven-resolver/commit/e1976767cf714da24336339f7a6286c6ab50986a
, there are many other locations where equivalent method has been removed (and
sometimes the Service interface implementation) without having known impact
should we add back these methods just for safety while at it?
was (Author: hboutemy):
method added back to the 2 classes that broke IDEA:
https://github.com/apache/maven-resolver/commit/b2eeafe26d5901abbdf341d2d8c6d68f08c5a99b
looking at MRESOLVER-36 fix
https://github.com/apache/maven-resolver/commit/e1976767cf714da24336339f7a6286c6ab50986a
, there are many other locations where equivalent method has been removed
without having known impact
should we add back these methods just for safety while at it?
> restore setLoggerFactory(...) API deleted from version 1.3.0
> ------------------------------------------------------------
>
> Key: MRESOLVER-64
> URL: https://issues.apache.org/jira/browse/MRESOLVER-64
> Project: Maven Resolver
> Issue Type: Wish
> Components: resolver
> Affects Versions: 1.3.0, 1.3.1
> Reporter: Hervé Boutemy
> Priority: Major
>
> during work on MRESOLVER-36 to switch from LoggerFactory to direct slf4j, 2
> setLoggerFactory(...) methods were removed since they are not strictly
> required now
> this broke Intellij IDEA Maven integration
> adding back these methods with empty implementation, marking them deprecated,
> would restore strict API compatibility without much complexity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
