[ 
https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714017#comment-16714017
 ] 

ASF GitHub Bot commented on MNG-6529:
-------------------------------------

eolivelli commented on a change in pull request #193: MNG-6529 - 
ProjectBuild.build(projectsList, ...) ignores request.isResolveDependency()
URL: https://github.com/apache/maven/pull/193#discussion_r240044205
 
 

 ##########
 File path: 
maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java
 ##########
 @@ -84,4 +87,22 @@ public void testVersionlessManagedDependency()
             // this is expected
         }
     }
+
+    public void testResolveDependencies() throws Exception {
+        File pomFile = new File( 
"src/test/resources/projects/basic-resolveDependencies.xml" );
+        MavenSession mavenSession = createMavenSession( null );
+        ProjectBuildingRequest configuration = new 
DefaultProjectBuildingRequest();
+        configuration.setRepositorySession( 
mavenSession.getRepositorySession() );
+        configuration.setResolveDependencies(true);
 
 Review comment:
   Can we add a test in which this is false and assert that resolution actually 
does not happen ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) 
> doesn't honor ProjectBuildingRequest.isResolveDependencies()
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MNG-6529
>                 URL: https://issues.apache.org/jira/browse/MNG-6529
>             Project: Maven
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.5.3
>            Reporter: Mickael Istria
>            Assignee: Robert Scholte
>            Priority: Critical
>             Fix For: 3.6.1
>
>
> I'm willing to upfate Eclipse m2e to take advantage of the 
> `ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)` 
> in Eclipse m2e to avoid duplication of MavenProject in the IDE in place of 
> `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's already 
> measured to have drastically good impact on the IDE, as explained in 
> [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and 
> [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
> However, using this cause regressions because the multi-projects entry-point 
> method seems to totally ignore the 
> `ProjectBuildRequest.isResolveDependencies()` flag and never returns a valid 
> list of `MavenProject.getArtifacts()`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to