sormuras commented on a change in pull request #209: Surefire 1614
URL: https://github.com/apache/maven-surefire/pull/209#discussion_r241303900
##########
File path:
surefire-its/src/test/resources/surefire-1614-stream-corruption/src/test/java/com/example/demo/CustomRunner.java
##########
@@ -0,0 +1,19 @@
+package com.example.demo;
+
+import org.junit.runners.BlockJUnit4ClassRunner;
+import org.junit.runners.model.InitializationError;
+import org.junit.runners.model.TestClass;
+
+public class CustomRunner extends BlockJUnit4ClassRunner {
Review comment:
All I'm saying is that when [an almost 2 hour running
build](https://builds.apache.org/job/maven-box/job/maven-surefire/job/SUREFIRE-1614/)
doesn't fail due to code formatting issues, everything's fine for me too.
> [...] use IDEA14 ad it is configured properly [...]
There are tools that a) format and b) check for style violations. We should
use them -- and not rely on personal IDEs, their proper configuration and hope
that stars align. If such tools were used you even gain speed when reviewing
PRs: a successful build means that all style checks passed. Yeah!
> You have to follow the code style
Sure. Still I expect from properly setup projects to notify me about code
style violations. A build should not even start to compile stuff when there are
code style violations present.
> I guess you want to work in ASF
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
