Serranya commented on a change in pull request #7: [MCHECKSTYLE-357] - Allow
inline configuration for reporting
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/7#discussion_r241376965
##########
File path:
src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java
##########
@@ -73,6 +74,10 @@
protected static final String JAVA_FILES = "**\\/*.java";
+ private static final String CHECKSTYLE_FILE_HEADER = "<?xml
version=\"1.0\"?>\n"
+ + "<!DOCTYPE module PUBLIC \"-//Puppy Crawl//DTD Check
Configuration 1.3//EN\"\n"
+ + "
\"http://www.puppycrawl.com/dtds/configuration_1_3.dtd\";>\n";
Review comment:
Thank you for your input. Much appreciated.
I aggree with you that hardwiring the DTD header might be a bad Idea. Your
suggestion
> My only idea for continuing with this PR is maybe give the user the option
specify configuration version and DTD ID, instead of hardcoding it. The default
can be what 6.18 supports.
Sounds reasonable
We should also allow overriding in the other mojo
https://github.com/apache/maven-checkstyle-plugin/blob/c4505ee038390f7f2ae90b441a0e0bbe963340d9/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java#L83-L85
What do you think @eolivelli ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
