rnveach commented on a change in pull request #7: [MCHECKSTYLE-357] - Allow
inline configuration for reporting
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/7#discussion_r241736646
##########
File path:
src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java
##########
@@ -73,6 +74,10 @@
protected static final String JAVA_FILES = "**\\/*.java";
+ private static final String CHECKSTYLE_FILE_HEADER = "<?xml
version=\"1.0\"?>\n"
+ + "<!DOCTYPE module PUBLIC \"-//Puppy Crawl//DTD Check
Configuration 1.3//EN\"\n"
+ + "
\"http://www.puppycrawl.com/dtds/configuration_1_3.dtd\";>\n";
Review comment:
DOCTYPE is required. Without it you will get `org.xml.sax.SAXParseException;
systemId: file:TestConfig.xml; lineNumber: 1; columnNumber: 8; Document is
invalid: no grammar found.` when you run Checkstyle's `ConfigurationLoader`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
