rfscholte commented on a change in pull request #11: [MSHADE-307] adding
useDefaultConfiguration flag in ShadeMojo
URL: https://github.com/apache/maven-shade-plugin/pull/11#discussion_r241986322
##########
File path: src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
##########
@@ -823,6 +844,50 @@ private File resolveArtifactSources( Artifact artifact )
}
}
+ // first check for backward compatibility this is not already
configured explicitly
+ boolean addExclusion = true;
Review comment:
We need a similar trick here:
public Collection<Filter> getFilters()
{
if ( this.filters == null )
{
return defaultFilters();
}
else
{
return this.filters;
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services