rmannibucau commented on a change in pull request #12: [MSHADE-307] defaults
for transformers and filters
URL: https://github.com/apache/maven-shade-plugin/pull/12#discussion_r243188080
##########
File path: src/test/java/org/apache/maven/plugins/shade/mojo/ShadeMojoTest.java
##########
@@ -60,6 +64,50 @@
public class ShadeMojoTest
extends PlexusTestCase
{
+ public void testDefaultConfiguration() throws Exception
Review comment:
Thought about it but I found it saner as a compromise cause this is really
more a whitebox test to check we mutate the user config as expected than an IT
which would be more complicated with fewer guarantee on what we do at that
level IMHO (here we really want to check the default config is setup and not
smoke test it, at least was the intention)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
