andretadeu commented on a change in pull request #3: [MWAR-371] Overlays break
first-win rule for web resource with target path ending with '/'
URL: https://github.com/apache/maven-war-plugin/pull/3#discussion_r243770770
##########
File path: src/main/java/org/apache/maven/plugins/war/util/PathSet.java
##########
@@ -113,7 +109,7 @@ public void addAll( Collection<String> paths, String
prefix )
{
for ( String val : paths )
{
- add( prefix + val );
+ add( Paths.get( prefix, val ).toString() );
Review comment:
This class does not eagerly traverse the File System, it just represents the
Path, parse it properly and returns a file when you call the method 'toFile()'.
If the file or the path does not exist, it won't complain unless you try to
open, check for files inside the folder, etc. It also deals with relative and
absolute paths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
