eolivelli commented on a change in pull request #15: Don't fail if module
source path already exists.
URL:
https://github.com/apache/maven-javadoc-plugin/pull/15#discussion_r243828901
##########
File path:
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -4754,11 +4754,11 @@ private void addJavadocOptions( File
javadocOutputDirectory,
addArgIfNotEmpty( arguments, "--patch-module",
moduleName + '='
+ JavadocUtil.quotedPathArgument(
getSourcePath( projectSourcepaths.getValue() ) ) );
- Files.createDirectory( moduleSourceDir.resolve(
moduleName ) );
+ Files.createDirectories( moduleSourceDir.resolve(
moduleName ) );
Review comment:
The semantics of this method are different from the ones of createDirectory.
If you only want to create the last path you should use
if !Files.isDirectory...createDirectory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
