Tibor17 commented on issue #212: [SUREFIRE-1546] JUnit 5 runner does not honor JUnit 5 display names URL: https://github.com/apache/maven-surefire/pull/212#issuecomment-450365372 yes. I only did not have much spare time to write the test. I will do it but meanwhile I wanted to know also from Christian if this is good change especially in the adapter class. On Thu, Dec 27, 2018 at 8:47 PM Enrico Olivelli <[email protected]> wrote: > *@eolivelli* requested changes on this pull request. > > Awesome work. > I left a couple of questions > ------------------------------ > > In > surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java > <https://github.com/apache/maven-surefire/pull/212#discussion_r244215312>: > > > return new PojoStackTraceWriter( className, methodName, throwable ); > } > > - private String getClassName( TestIdentifier testIdentifier ) > + private String[] toClassMethodName( TestIdentifier testIdentifier ) > > Is there any particular reason for using an array and not a struct? It > will be more clear and error prone > ------------------------------ > > In > surefire-its/src/test/resources/junit-platform/src/test/java/junitplatform/DisplayNameTest.java > <https://github.com/apache/maven-surefire/pull/212#discussion_r244215535>: > > > + * KIND, either express or implied. See the License for the > + * specific language governing permissions and limitations > + * under the License. > + */ > + > +import org.junit.jupiter.api.DisplayName; > +import org.junit.jupiter.api.Test; > + > +import java.util.logging.Logger; > + > +class DisplayNameTest > +{ > + private static final Logger LOGGER = Logger.getLogger( DisplayNameTest.class.getName() ); > + > + @Test > + @DisplayName( "Custom test name containing spaces" ) > > Would it be useful to have some unit test around display name which > contains '(' and ')' ? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/maven-surefire/pull/212#pullrequestreview-188163849>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA_yRzuL63hh4Kt-v4DVnKbe3AU0IycNks5u9SO6gaJpZM4ZjG6Q> > . > -- Cheers Tibor
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
