[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Turner updated MCHECKSTYLE-365:
--------------------------------------
    Description: 
When the site report is generated, in the Rules section, the plug-in groups 
together the violation counts for rules that have the same name and message, 
but that have different severity levels -- specifically where one of the rules 
doesn't specify a severity level and uses the default ({{error}}). This results 
in both rules being listed with different properties and severity levels, but 
with the same violation count (which is incorrect).

Also note that adding a unique {{id}} attribute to each of the rules also does 
not result in the violation counts being aggregated correctly. (the proposed 
patch does not address this aspect).

To be correct, the report should use the same criteria for determining unique 
rules as it does for aggregating the violation counts for each rule.

A simple user work-around for some rules (such as {{RegexpSingleline}}) is to 
change the {{message}} property for each of the rules with different severity 
levels. However, this doesn't work for other rules, such as 
{{FileTabCharacter}}.

I will attach a screenshot of the issue manifesting itself, and I will attach a 
proposed patch (which I can convert into a PR if the maintainers deem this to 
be the right approach to solving this issue).

  was:
When the site report is generated, in the Rules section, the plug-in groups 
together the violation counts for rules that have the same name and message, 
but that have different severity levels -- specifically where one of the rules 
doesn't specify a severity level and uses the default ({{error}}). This results 
in both rules being listed with different properties and severity levels, but 
with the same violation count (which is incorrect).

To be correct, the report should use the same criteria for determining unique 
rules as it does for aggregating the violation counts for each rule.

A simple user work-around for some rules (such as {{RegexpSingleline}}) is to 
change the {{message}} property for each of the rules with different severity 
levels. However, this doesn't work for other rules, such as 
{{FileTabCharacter}}.

I will attach a screenshot of the issue manifesting itself, and I will attach a 
proposed patch (which I can convert into a PR if the maintainers deem this to 
be the right approach to solving this issue).


> In the Rules section of the site report, violation counts are grouped 
> together incorrectly for rules of the same type and message but with 
> different severity levels
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-365
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-365
>             Project: Maven Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Turner
>            Priority: Trivial
>         Attachments: MCHECKSTYLE-365.patch, Screen Shot 2018-12-31 at 
> 14.43.18.png
>
>
> When the site report is generated, in the Rules section, the plug-in groups 
> together the violation counts for rules that have the same name and message, 
> but that have different severity levels -- specifically where one of the 
> rules doesn't specify a severity level and uses the default ({{error}}). This 
> results in both rules being listed with different properties and severity 
> levels, but with the same violation count (which is incorrect).
> Also note that adding a unique {{id}} attribute to each of the rules also 
> does not result in the violation counts being aggregated correctly. (the 
> proposed patch does not address this aspect).
> To be correct, the report should use the same criteria for determining unique 
> rules as it does for aggregating the violation counts for each rule.
> A simple user work-around for some rules (such as {{RegexpSingleline}}) is to 
> change the {{message}} property for each of the rules with different severity 
> levels. However, this doesn't work for other rules, such as 
> {{FileTabCharacter}}.
> I will attach a screenshot of the issue manifesting itself, and I will attach 
> a proposed patch (which I can convert into a PR if the maintainers deem this 
> to be the right approach to solving this issue).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to