rfscholte commented on a change in pull request #7: [MPIR-375] add plugin
excludes feature for plugin-management report
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/7#discussion_r247357917
##########
File path:
src/main/java/org/apache/maven/report/projectinfo/PluginManagementReport.java
##########
@@ -200,13 +220,21 @@ private void renderSectionPluginManagement()
Artifact pluginArtifact =
repositorySystem.createProjectArtifact( plugin.getGroupId(), plugin
.getArtifactId(), versionRange.toString() );
-
+
try
{
- MavenProject pluginProject = projectBuilder.build(
pluginArtifact, buildingRequest ).getProject();
-
- tableRow( getPluginRow( pluginProject.getGroupId(),
pluginProject.getArtifactId(), pluginProject
- .getVersion(), pluginProject.getUrl() ) );
+ if ( isExcluded( pluginArtifact ) )
+ {
+ log.debug( "Excluding plugin " +
pluginArtifact.getId() + " from report" );
+ }
+ else
+ {
+ MavenProject pluginProject =
Review comment:
Can you the try-catch statement inside the else-statement, not around the
whole if-else statement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
