rfscholte commented on a change in pull request #1: [MJMOD-20] set jmod 
--main-class argument if it is set.
URL: https://github.com/apache/maven-jmod-plugin/pull/1#discussion_r248797214
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java
 ##########
 @@ -587,6 +587,12 @@ private Commandline createJModCreateCommandLine( File 
resultingJModFile )
             argsFile.println( getPlatformSeparatedList( configList ) );
         }
 
+        if ( mainClass != null && !mainClass.trim().isEmpty() )
 
 Review comment:
   No need to trim, all pom elements are being trimmed by default. If there's a 
StringUtils available, consider using that class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to