[ http://jira.codehaus.org/browse/MJAVADOC-105?page=all ]

Julien HENRY updated MJAVADOC-105:
----------------------------------

    Attachment: javadoc-exclude-package.patch

This patch fix the problem for me, and doesn't break any test case.

> Excluded package is generated (should not) because of wrong file separator.
> ---------------------------------------------------------------------------
>
>                 Key: MJAVADOC-105
>                 URL: http://jira.codehaus.org/browse/MJAVADOC-105
>             Project: Maven 2.x Javadoc Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>         Environment: Windows
>            Reporter: Julien HENRY
>         Attachments: javadoc-exclude-package.patch
>
>
> I'm using javacc plugin to generate source. By default, sources are generated 
> in ${project.build.directory}/generated-sources/javacc
> I set Javacc to generate sources in package net.sourceforge.jwebunit.javacc
> As I don't want Javadoc to be generated for the parser, I set 
> excludePackageNames to net.sourceforge.jwebunit.javacc in my POM.
> With my configuration, the full path of Javacc generated sources is : 
> D:\jhenry\jwebunit-1.x\jwebunit-webtestcase-generator\target/generated-sources/javacc
>  (note that there is "/" and "\" in the same path).
> Now, in the function AbstractJavadocMojo.getIncludedFiles, you are trying to 
> exclude package by comparing string 
> D:\jhenry\jwebunit-1.x\jwebunit-webtestcase-generator\target\generated-sources\javacc\net\sourceforge\jwebunit\javacc\
> and
> D:\jhenry\jwebunit-1.x\jwebunit-webtestcase-generator\target/generated-sources/javacc
>  + \net\sourceforge\jwebunit\javacc\
> and the two Strings are not equal because of "/" and "\"
> Perhaps it's a bug of javacc, but this method should be more robust (for 
> example by using File comparisons instead of String comparisons).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to