[
https://issues.apache.org/jira/browse/MSHARED-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753210#comment-16753210
]
Michael Osipov edited comment on MSHARED-796 at 1/26/19 10:48 PM:
------------------------------------------------------------------
[~hboutemy], while picking up MSHARED-787 I am not really happy having the
semantics of {{Build-Jdk}} changed and having it changed again when build env
entries are added. I'd rather see a new property introduced for
preproducibility. Instead abusing {{Build-Jdk}} why now have it named
{{Java-Spec-Version}} or {{Jdk-Spec-Version}}? It shall be clearly distinct
from {{Build-*}} because the new value won't change as long as you stay with
the same spec version..
was (Author: michael-o):
[~hboutemy], while picking up MSHARED-787 is a not really happy having the
semantics of {{Build-Jdk}} changed and having it changed again when build env
entries are added. I'd rather see a new property introduced for
preproducibility. Instead abusing {{Build-Jdk}} why now have it named
{{Java-Spec-Version}} or {{Jdk-Spec-Version}}. It shall be clearly distinct
from {{Build-*}} because the new value won't change as long as you stay with
the same spec version..
> use java.specification.version instead of java.version in Build-Jdk manifest
> entry
> ----------------------------------------------------------------------------------
>
> Key: MSHARED-796
> URL: https://issues.apache.org/jira/browse/MSHARED-796
> Project: Maven Shared Components
> Issue Type: Wish
> Components: maven-archiver
> Affects Versions: maven-archiver-3.3.0
> Reporter: Hervé Boutemy
> Assignee: Hervé Boutemy
> Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> as part or reproducible builds efforts, we're removing manifest entries that
> are hard to reproduce and do not add much value.
> In MSHARED-661, we removed "Built-By: <username>" entry, but decided to keep
> "Build-Jdk" entry
> the idea here is not to remove "Build-Jdk" entry but to replace its value
> from too much detailed java.version system property (which details the patch
> level) to java.specification.version: the specification has an impact on the
> generated bytecode, then is useful to keep, but at least we'll avoid patch
> level information
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)