Tibor17 commented on a change in pull request #217: Set properties readonly
where it doesn't make sense to change values
URL: https://github.com/apache/maven-surefire/pull/217#discussion_r251230003
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -197,7 +197,7 @@
* The base directory of the project being tested. This can be obtained in
your integration test via
* System.getProperty("basedir").
*/
- @Parameter( defaultValue = "${basedir}" )
+ @Parameter( defaultValue = "${basedir}", readonly = true )
Review comment:
I checked the history in 2012 and this was `required` but not `readonly`.
IMHO we should keep it and put `required` to `testClassesDirectory`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
