[
https://issues.apache.org/jira/browse/SCM-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761553#comment-16761553
]
Clemens Quoß edited comment on SCM-917 at 2/6/19 7:44 AM:
----------------------------------------------------------
Michael, I tried to push the SCM-917 branch for the pull request, but it seems
I lack authority:
remote: Permission to apache/maven-scm.git denied to cquoss.
What is the proper way to hand in the pull request?
Some questions remain:
* What use has the SCM Manager API? It seems outdated.
* How are the TckTest classes being run? Some of them (JGit for example) are
running during normal build. I provided 'normal' and Tck svn untag tests, but
I see only the normal tests.
* Do you want me to provide an UntagMojo Test for Subversion in the plugin
tests?
* Should I fix the checkstyle error in jgit? Classes JGitCheckoutCommand,
JGitTransportConfigCallbak, JGitUtils and JGitRemoteInfoCommand produce > 100
checkstyle errors in sum.
Regards,
Clemens
was (Author: cquoss):
Michael, I tried to push the SCM-917 branch for the pull request, but it seems
I lack authority:
remote: Permission to apache/maven-scm.git denied to cquoss.
What is the proper way to hand in the pull request?
Some questions remain:
* What use has the SCM Manager API? It seems outdated.
* How are the TckTest classes being run? Some of them (JGit for example) are
running during normal build. I provided 'normal' and Tck svn untag tests, but
I see only the normal tests.
* Do you want me to provide an UntagMojo Test for Sobversion in the plugin
tests?
* Should I fix the checkstyle error in jgit? Classes JGitCheckoutCommand,
JGitTransportConfigCallbak, JGitUtils and JGitRemoteInfoCommand produce > 100
checkstyle errors in sum.
Regards,
Clemens
> Implement scm:untag for Subversion provider
> -------------------------------------------
>
> Key: SCM-917
> URL: https://issues.apache.org/jira/browse/SCM-917
> Project: Maven SCM
> Issue Type: Improvement
> Components: maven-scm-provider-svn
> Affects Versions: 1.11.1
> Reporter: Clemens Quoß
> Priority: Critical
> Fix For: waiting-for-feedback
>
> Attachments: git-diff-master.out, image-2019-02-02-16-57-33-664.png
>
>
> In order to work on MRELEASE-229, I would like to provide a PR for SCM to
> enable remote removal for provider svn.
> Short outline:
> Introducing new parameter on scm:remove "remoteRemove" (alternative: use
> pushChanges for this for svn, but this might be confusing).
> Implementation:
> New execute method in SvnRemoveCommand using a new ScmRemoveParameters
> carrying this new parameter. If true, use url from repository as base to
> construct targets from scm file set in command line.
> [UPDATE] - Implementation of scm:untag command will now be the target of this
> issue (follow comment discussion)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
