michael-o commented on a change in pull request #88: SCM-917 add untag for svn
URL: https://github.com/apache/maven-scm/pull/88#discussion_r255269948
##########
File path:
maven-scm-api/src/main/java/org/apache/maven/scm/command/untag/AbstractUntagCommand.java
##########
@@ -31,18 +31,27 @@
public abstract class AbstractUntagCommand
extends AbstractCommand
{
+ /**
+ * SCM-917 - scm:untag for subversion
+ * @param repository scm repo
+ * @param fileSet set of files (unused)
+ * @param tagName tag name to remove
+ * @param message to use for commit comment
+ * @return result of untag command
+ * @throws ScmException in case of error
+ */
protected abstract ScmResult executeUntagCommand( ScmProviderRepository
repository,
- ScmFileSet fileSet, String tagName )
- throws ScmException;
+ ScmFileSet fileSet, String tagName, String message ) throws
ScmException;
Review comment:
Why aren't you using the same approach as Tag does with `ScmTagParameters
scmTagParameters` instead of the pure message? It would look consistent in my
opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
